Adjust the design of FedML Python Agent to a decentralized architecture that supports Launch Master, Launch Slave, Deploy Master, and Deploy Slave at the same time. #2163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alexleung/dev v070 for refactor
…ed architecture that supports Launch Master, Launch Slave, Deploy Master, and Deploy Slave at the same time.
Dev/v0.7.0
Dev/v0.7.0
Alexleung/dev branch latest
[CoreEngine] make the multiprocess work on windows, linux and mac.
[CoreEngine] make the status center work in the united agents.
alaydshah
reviewed
Jun 14, 2024
…tatus center and message center to agents.
[CoreEngine] refactor to support to pass the communication manager, s…
…tatus center and message center to agents.
[CoreEngine] refactor to support to pass the communication manager, s…
…es when the job is completed in the master server.
[CoreEngine] stop the status center, message center and other process…
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 11782617 | Triggered | Generic High Entropy Secret | 0491bb7 | .github/workflows/registry-runners/Dockerfile | View secret |
| 11782617 | Triggered | Generic High Entropy Secret | 7a0963e | .github/workflows/registry-runners/windows.bat | View secret |
| 11782617 | Triggered | Generic High Entropy Secret | 942b223 | .github/workflows/registry-runners/Dockerfile | View secret |
| 11782617 | Triggered | Generic High Entropy Secret | fd038b5 | .github/workflows/registry-runners/Dockerfile | View secret |
| 11782617 | Triggered | Generic High Entropy Secret | 942b223 | .github/workflows/registry-runners/windows.bat | View secret |
| 11782618 | Triggered | Generic High Entropy Secret | 0491bb7 | .github/workflows/registry-runners/windows.ps1 | View secret |
| 11782618 | Triggered | Generic High Entropy Secret | fd038b5 | .github/workflows/registry-runners/windows.ps1 | View secret |
| 11782618 | Triggered | Generic High Entropy Secret | 7a0963e | .github/workflows/registry-runners/windows.ps1 | View secret |
| 9453265 | Triggered | Generic High Entropy Secret | 942b223 | python/fedml/api/api_test.py | View secret |
| 9453265 | Triggered | Generic High Entropy Secret | 7233d62 | python/fedml/api/api_test.py | View secret |
| 9453265 | Triggered | Generic High Entropy Secret | aa813a0 | python/fedml/api/api_test.py | View secret |
| 9453265 | Triggered | Generic High Entropy Secret | 11ef2a5 | python/fedml/api/api_test.py | View secret |
| 9453265 | Triggered | Generic High Entropy Secret | 78e310c | python/fedml/api/api_test.py | View secret |
| 5692101 | Triggered | Generic High Entropy Secret | a932082 | python/fedml/computing/scheduler/model_scheduler/device_model_deployment.py | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
…ltiprocessing lock problem.
[CoreEngine] replace the queue with the managed queue to avoid the mu…
[CoreEngine] check the nil pointer and update the numpy version.
[CoreEngine] remove the deprecated action runners.
[CoreEngine] remove the unused files.
…d not stop the message center and status center.
[CoreEngine] when the deploy master reports finished status, we shoul…
[CoreEngine] Fix the stuck issue in the deploy master agent.
…ocess name to each python process.
[CoreEngine] in order to debug easily for multiprocessing, add the pr…
[CoreEngine] update the dependant libs.
…ant binding codes for deployment devices, change the account manager,
Alexleung/dev branch latest
[TEST]: Initialize a GitHub Actions framework for CI tests
Sync to lates dev branch.
Alexleung/dev branch latest
alaydshah
approved these changes
Jun 28, 2024
|
We can try to adopt this design discussed in thread and use Draft PR as reference in another branch if @fedml-alex has bandwidth: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.